cryptonas/cryptonas-branches
3
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity

some comments and changes for the previous commit

Browse source
This commit is contained in:
lars 2006-09-06 13:13:17 +00:00
parent 7f9c736116
commit 0835144ad1
3 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
pythonrewrite/bin2/CryptoBoxWebserverSettings.py
View file

@ -13,6 +13,7 @@ class CryptoBoxWebserverSettings:
## RFC: arbitrarily importing all available keys does not sound very secure [l] ## RFC: arbitrarily importing all available keys does not sound very secure [l]
## RFC: settings with the same names in different sections (Log, Main, ...) will collide silently - right? [l] ## RFC: settings with the same names in different sections (Log, Main, ...) will collide silently - right? [l]
## yep, we'll have to divide between settings for clearsilver and settings we need for other webstuff [a] ## yep, we'll have to divide between settings for clearsilver and settings we need for other webstuff [a]
## I think it would be better to expose only the necessary settings (manually - not just everything) [l]
for key in self.cbxPrefs["WebSettings"].keys(): for key in self.cbxPrefs["WebSettings"].keys():
website.settings["Settings."+key] = self.cbxPrefs["WebSettings"][key] website.settings["Settings."+key] = self.cbxPrefs["WebSettings"][key]
## also all Log values ## also all Log values

5
pythonrewrite/bin2/CryptoBoxWebserverSites.py
View file

@ -48,6 +48,7 @@ class CryptoBoxWebserverSites(CryptoBox.CryptoBoxProps, CryptoBoxWebserverSettin
''' '''
# RFC: this dictionary is not sufficient for arbitrary text inputs (e.g.: names) or numbers [l] # RFC: this dictionary is not sufficient for arbitrary text inputs (e.g.: names) or numbers [l]
# what way would we sanizite such input? just exclude forbidden elements? [a] # what way would we sanizite such input? just exclude forbidden elements? [a]
# I would prefer a seperate function for each possible setting [l]
niceparams = { niceparams = {
'weblang': ["Settings.Language", self.settings["Settings.AvailableLanguages"]], 'weblang': ["Settings.Language", self.settings["Settings.AvailableLanguages"]],
'loglevel': ["Log.Level", ('','info', 'warn', 'debug', 'error')], 'loglevel': ["Log.Level", ('','info', 'warn', 'debug', 'error')],
@ -64,6 +65,7 @@ class CryptoBoxWebserverSites(CryptoBox.CryptoBoxProps, CryptoBoxWebserverSettin
if evilparams[nicekey] and evilparams[nicekey] in niceparams[nicekey][1]: if evilparams[nicekey] and evilparams[nicekey] in niceparams[nicekey][1]:
# RFC: isn't "self.settings" a non-obvious name for user input? [l] # RFC: isn't "self.settings" a non-obvious name for user input? [l]
# self.settings is used by clearsilver [a] # self.settings is used by clearsilver [a]
# yes, but why should clearsilver have access to the user input? [l]
self.settings[niceparams[nicekey][0]] = evilparams[nicekey] self.settings[niceparams[nicekey][0]] = evilparams[nicekey]
#self.log.warn(niceparams[nicekey][0]) #self.log.warn(niceparams[nicekey][0])
#self.log.warn(evilparams[nicekey]) #self.log.warn(evilparams[nicekey])
@ -156,8 +158,9 @@ class CryptoBoxWebserverSites(CryptoBox.CryptoBoxProps, CryptoBoxWebserverSettin
self.settings["Data.Error"] = "NoDocumentation" self.settings["Data.Error"] = "NoDocumentation"
# TODO: what should be done, if there is an error? # TODO: what should be done, if there is an error?
# do you mean this is not an error? [a] # do you mean this is not an error? [a]
# it is, but the current action is still "show_doc" - despite the error - maybe "blank" would be better? [l]
## set doclang to weblang, otherwise the default weblang from the config will be used for doclang ## set doclang to weblang, otherwise the default weblang from the config will be used for doclang
elif self.settings["Settings.Language"] in ["Settings.AvailableDocLanguages"]: elif self.settings["Settings.Language"] in self.settings["Settings.AvailableDocLanguages"]:
self.settings["Settings.DocLang"] = self.settings["Settings.Language"] self.settings["Settings.DocLang"] = self.settings["Settings.Language"]
# TODO: missing 'else'? # TODO: missing 'else'?

2
pythonrewrite/scripts/userdocexport.sh
View file

@ -29,7 +29,7 @@ WIKI_HOST="https://systemausfall.org"
# the trailing slash is important # the trailing slash is important
WIKI_URL=/trac/cryptobox/wiki/ WIKI_URL=/trac/cryptobox/wiki/
CBOX_CGI="?page=" CBOX_CGI="/doc?page="
LANGUAGES="de en" LANGUAGES="de en"